This is looking really good. Love the wiki, love the use of issues and issue template. Really digging the landing README.md and the description and flow / overview diagrams. Solid group of tests.
A few minor things:
[x] Check your .gitignore - I see some files like .ipynb_checkpoints and __pycache__
[x] I notice some notebooks in the package directory. These should probably be moved to examples or cleaned up. project_scoping.md probably needs a new home.
[x] Multiline comments / strings should be triple double quotes not triple single (see unit tests).
[x] No setup.py or travis.yml. Since your project is nearly perfect, getting a simple setup.py would really finish it off and implementing continuous integration via travis would really make it shine.
This is looking really good. Love the wiki, love the use of issues and issue template. Really digging the landing README.md and the description and flow / overview diagrams. Solid group of tests.
A few minor things:
[x] Check your
.gitignore- I see some files like.ipynb_checkpointsand__pycache__[x] I notice some notebooks in the package directory. These should probably be moved to examples or cleaned up. project_scoping.md probably needs a new home.
[x] Multiline comments / strings should be triple double quotes not triple single (see unit tests).
[x] No setup.py or travis.yml. Since your project is nearly perfect, getting a simple setup.py would really finish it off and implementing continuous integration via travis would really make it shine.