Add support for Guzzle 7

theiconic / php-ga-measurement-protocol

Send data to Google Analytics from the server using PHP. Implements GA measurement protocol.

MIT License

655 stars 136 forks source link

Add support for Guzzle 7 #89

Closed irazasyed closed 3 years ago

irazasyed commented 4 years ago

Please merge this ASAP as Laravel 8 is releasing today and as you know, Laravel GAMP is dependent on this library. Laravel 8 requires Guzzle 7, so until this PR is merged, users of Laravel GAMP won't be able to use the package in Laravel 8.

I checked the libs code to see if there could be any issues in upgrading to Guzzle 7 but so far found none that could break it but I haven't tested this yet.

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 42b859493fc636678c1481ecaf9262723f624372 on irazasyed:patch-1 into 391e3c5c82fbcdb41936caff9f848c193cd56790 on theiconic:master.

irazasyed commented 4 years ago

Hey @jorgeborges! Hope you're doing great :)

Could you please take a look at this when you get a chance? Thanks!

dmyers commented 3 years ago

Trying to upgrade to Laravel v8 myself too! Thanks for contributing and I hope it gets approved and merged soon.

Even if you don't use that Laravel GAMP project, but want to still upgrade to Laravel 8, it's not possible until Guzzle is updated so it's very necessary for anyone who is using the newer Guzzle version.

amaelftah commented 3 years ago

@dmyers i think upgrading guzzle isn't needed check this comment https://github.com/laravel/laravel/pull/5381#issuecomment-689101352

jorgeborges commented 3 years ago

OK, since we are not expecting that this would break anything, I'll release as a minor version.

jorgeborges commented 3 years ago

Also, thanks @luads for the review.

irazasyed commented 3 years ago

Thanks 👍