search

theintern / digdug

A JavaScript library for launching WebDriver service tunnels.
https://theintern.github.io/digdug/
Other
44 stars 28 forks source link

kill child process when killing the parent process #68

Closed qiuzuhui closed 5 years ago

qiuzuhui commented 5 years ago

child process still running when killing the parent process on windows.

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

jason0x43 commented 5 years ago

There's not a lot of background here. Is this happening with a particular Tunnel subclass? Is there some reason that _stop, which explicitly stops the child, isn't stopping the child?

qiuzuhui commented 5 years ago

There's not a lot of background here. Is this happening with a particular Tunnel subclass? Is there some reason that _stop, which explicitly stops the child, isn't stopping the child?

it happens when I use chrome for testing on windows, and Ctrl + C to stop the testing task, the chromedriver.exe still running on the background (which cause my next CI job not work because the folder is locked)