search

theintern / intern

A next-generation code testing stack for JavaScript.
https://theintern.io/
Other
4.36k stars 311 forks source link

Environment resolution creates duplicate environments #1064

Closed jason0x43 closed 4 years ago

jason0x43 commented 4 years ago

In Intern 5-pre, the current environment resolution code can produce duplicate environments. This is happening because some normalization code that ensures environments have both JWP and W3C specifiers (e.g., both browser and browserName) is running before normalization, and permutations are being made from the duplicate properties.

Ideally, Intern should use a canonical representation internally (just W3C, for example), and do any expansion or adjustment after environments have been resolved.

jason0x43 commented 4 years ago

Resolved by 85101e90a (that commit accidentally referenced 1065 instead of this one).