theintern / intern

A next-generation code testing stack for JavaScript.
https://theintern.io/
Other
4.36k stars 309 forks source link

Command.ts is being included in the browser build #1067

Closed jason0x43 closed 4 years ago

jason0x43 commented 4 years ago

In Intern master, the webpack build, which should only include generic and browser code (no Node code) is trying to include Command.ts.

[testIntern] [webpack]     Entrypoint config = config.js
[testIntern] [webpack]     ERROR in /Users/jason/Documents/Work/src/intern/intern/src/webdriver/Command.ts
[testIntern] [webpack]     [tsl] ERROR in /Users/jason/Documents/Work/src/intern/intern/src/webdriver/Command.ts(697,3)
[testIntern] [webpack]           TS7023: 'catch' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.
jason0x43 commented 4 years ago

Closing this because I can't reproduce it with current master. For the record, the command that was running for testIntern in the issue description was:

ts-node scripts/build.ts -o testIntern --watch