Closed samends closed 4 years ago
@jason0x43 I'm running into an issue where the lifecycle methods are emitting these warning logs. I'm unsure how to keep these from emitting while also testing to make sure the lifecycle methods emit warnings
Merging #1116 into master will decrease coverage by
0.06%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
- Coverage 57.44% 57.38% -0.07%
==========================================
Files 95 95
Lines 8909 8909
Branches 2046 2046
==========================================
- Hits 5118 5112 -6
- Misses 3791 3797 +6
Impacted Files | Coverage Δ | |
---|---|---|
src/core/lib/interfaces/object.ts | 14.81% <0%> (ø) |
:arrow_up: |
src/common/lib/request.ts | 52.2% <0%> (-0.74%) |
:arrow_down: |
src/webdriver/Server.ts | 33.93% <0%> (-0.61%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2297e7b...19a060a. Read the comment docs.
@jason0x43 updated per your comments, try reviewing again
This updates the warning log in the
core/lib/interfaces/object
file to useexecuter.emit
resolves: #1104