theintern / intern

A next-generation code testing stack for JavaScript.
https://theintern.io/
Other
4.36k stars 309 forks source link

Updated browserVersion and version to behave the same #1117

Open samends opened 4 years ago

samends commented 4 years ago

When version is set to insider preview and browserName is MicrosoftEdge, the driver name should be MicrosoftEdgeChromium

resolves: #1113

jsf-clabot commented 4 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 4 years ago

Codecov Report

Merging #1117 into master will decrease coverage by 0.1%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   57.44%   57.34%   -0.11%     
==========================================
  Files          95       95              
  Lines        8909     8911       +2     
  Branches     2046     2048       +2     
==========================================
- Hits         5118     5110       -8     
- Misses       3791     3801      +10
Impacted Files Coverage Δ
src/core/lib/executors/Node.ts 90% <0%> (-0.35%) :arrow_down:
src/tunnels/BrowserStackTunnel.ts 80.53% <0%> (-1.77%) :arrow_down:
src/common/lib/request.ts 52.2% <0%> (-0.74%) :arrow_down:
src/webdriver/Server.ts 33.93% <0%> (-0.61%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2297e7b...c44d62b. Read the comment docs.