Closed jonnycornwell closed 4 years ago
Not sure what went on there in the build, did run the tests on node, chrome and firefox locally. Also if you want me to remove the api.json
changes let me know
Merging #1125 into master will increase coverage by
0.25%
. The diff coverage is94.64%
.
@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
+ Coverage 57.44% 57.69% +0.25%
==========================================
Files 95 96 +1
Lines 8909 8962 +53
Branches 2046 2059 +13
==========================================
+ Hits 5118 5171 +53
Misses 3791 3791
Impacted Files | Coverage Δ | |
---|---|---|
src/core/bin/intern.ts | 26.47% <33.33%> (+1.11%) |
:arrow_up: |
src/core/lib/node/util.ts | 27.55% <50.00%> (+0.46%) |
:arrow_up: |
src/core/lib/Suite.ts | 98.34% <100.00%> (+<0.01%) |
:arrow_up: |
src/core/lib/Test.ts | 98.43% <100.00%> (-0.23%) |
:arrow_down: |
src/core/lib/common/time.ts | 100.00% <100.00%> (ø) |
|
src/core/lib/executors/Node.ts | 90.35% <100.00%> (+0.01%) |
:arrow_up: |
src/tunnels/BrowserStackTunnel.ts | 81.41% <0.00%> (-0.89%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8fb1208...1c670fd. Read the comment docs.
@jason0x43 Is there any chance of getting this change into the next 4.8.X release?
Yes, that should be doable
Great, thanks!