theintern / intern

A next-generation code testing stack for JavaScript.
https://theintern.io/
Other
4.36k stars 310 forks source link

Documentation example code uses `getPlugin` instead of `getInterface` #1162

Closed msssk closed 4 years ago

msssk commented 4 years ago

There are various bits of documentation with code like:

const { suite, test } = intern.getPlugin('interface.tdd');

It should use getInterface instead of getPlugin:

const { suite, test } = intern.getInterface('interface.tdd');

The problem also exists in https://github.com/theintern/intern-tutorial

jason0x43 commented 4 years ago

All the documentation uses getPlugin; this is intentional (https://github.com/theintern/intern/issues/875).

In Intern 5 the interfaces will be available directly on the executor, so you won't even need getPlugin for that.

msssk commented 4 years ago

So I guess the problem is the opposite: https://theintern.io/docs.html#Intern/4/api/lib%2Finterfaces%2Fobject https://theintern.io/docs.html#Intern/4/api/lib%2Finterfaces%2Ftdd These both demonstrate getInterface

jason0x43 commented 4 years ago

Oops, I thought I had gotten rid of all the references to getInterface. Apparently I missed some.