search

theintern / intern

A next-generation code testing stack for JavaScript.
https://theintern.io/
Other
4.36k stars 311 forks source link

Fix circular references #1185

Closed rhpijnacker closed 3 years ago

rhpijnacker commented 3 years ago

Fixes situations where an AssertionError is sent that contains circular references.

jason0x43 commented 3 years ago

What about expanding the stringify function in common/lib/util to handle Errors and then using it?

rhpijnacker commented 3 years ago

As suggested on Gitter, reworked it to a more generic solution, using this MDN snippet as the basis.

jason0x43 commented 3 years ago

Please retarget the PR against master (the monorepo conversion was put on hold, and dev switched back to that). Also, we'll probably need to import a core-js shim (src/lib/browser/shim.ts) for WeakMap since IE doesn't support that.

rhpijnacker commented 3 years ago

Replaced with #1188 .