search

theintern / intern

A next-generation code testing stack for JavaScript.
https://theintern.io/
Other
4.36k stars 310 forks source link

SauceLabs version should be configurable instead of hardcoded #599

Closed Delvach closed 8 years ago

Delvach commented 8 years ago

My organization is currently using intern for testing, and have run into periodic timeouts with SauceConnect that sound like they may be alleviated by upgrading to the latest version. It looks like SauceConnect is currently hardcoded to '4.3' within the digdug project.

As I'm just getting into this project I'm hesitant to create any pull requests on either repo myself, but it would be helpful to have a configurable SAUCE_VERSION.

jason0x43 commented 8 years ago

This feature will be included in the next release of Dig Dug.

jason0x43 commented 8 years ago

Fixed in https://github.com/theintern/digdug/commit/bcb3c40bf44e5f116fa7b72331f8f7f69788a947

colmsnowplow commented 5 years ago

Thanks for this feature, it was the solution to a dependency issue I've been struggling with for a solid week.

I didn't find it anywhere in the documentation though - not sure this warrants its own issue so adding this comment to suggest that it would be useful for those in a similar position to mine if it were added to this page :) : https://theintern.io/digdug/module-digdug_SauceLabsTunnel.html

jason0x43 commented 5 years ago

@colmsnowplow That property is documented in the current docs at https://theintern.io/docs.html#Dig%20Dug/2/api/SauceLabsTunnel/scversion. The documentation at https://theintern.io/digdug/module-digdug_SauceLabsTunnel.html is for an earlier version of Dig Dug.

colmsnowplow commented 5 years ago

My mistake, thanks for pointing that out!