search

theintern / intern

A next-generation code testing stack for JavaScript.
https://theintern.io/
Other
4.36k stars 309 forks source link

leaveRemoteOpen isn't working in 4.2.0 #911

Closed jason0x43 closed 6 years ago

jason0x43 commented 6 years ago

The leaveRemoteOpen option should leave a remote browser open after the testing process. This is working in 4.1.5, but not in 4.2.0.

AlonMiz commented 6 years ago

+1

bthallion commented 6 years ago

I'm also having this problem

jason0x43 commented 6 years ago

Tricky. So, the problem isn't with Intern but with Dig Dug, which is what actually manages the remote browsers. A longstanding issue with Dig Dug was that it would often leave webdriver processes running after a testing session because Selenium wasn't great about cleaning them up. It turns out that's what was allowing leaveRemoteOpen to work. The most recent versions of Dig Dug use a more aggressive kill routine when stopping tunnels; in addition to ensuring the webdriver processes are killed along with Selenium, this routine also kills the browser processes started by the webdrivers.

jason0x43 commented 6 years ago

I added a somewhat less aggressive kill function to Dig Dug and that seems to be doing the trick. Assuming the tests pass, I'll release a new version.

jason0x43 commented 6 years ago

This is fixed in https://github.com/theintern/digdug/commit/8cb1ed2db2ddb8313f6e69aa6f685a84b351f436 and is part of digdug 2.1.1.