theintern / leadfoot

A JavaScript client library that brings cross-platform consistency to the Selenium WebDriver API.
Other
170 stars 24 forks source link

Handle window size check in Firefox 53+ #108

Closed jason0x43 closed 7 years ago

jason0x43 commented 7 years ago

Firefox 53 hangs when Leadfoot makes window size checks during feature detection. Geckodriver 16 and the WebDriver standard point out what the size call is now window/x/rect, so getWindowSize and setWindowSize should use those methods where necessary.

The feature tests will need to check for FF 53 and set a capability indicating that it uses window/x/rect instead of window/x/size.

jason0x43 commented 7 years ago

I lied, it's just window/rect.

jason0x43 commented 7 years ago

Hmmm...doing a window/rect check appears to hang Sauce Labs VMs.

jason0x43 commented 7 years ago

This was fixed in release 1.7.2.