search

theintern / leadfoot

A JavaScript client library that brings cross-platform consistency to the Selenium WebDriver API.
Other
170 stars 24 forks source link

setWindowPosition isn't working with recent Firefox #126

Closed jason0x43 closed 7 years ago

jason0x43 commented 7 years ago

setWindowPosition should be using the window/rect command like setWindowSize. Currently it's using window/current/position, which doesn't error, but doesn't work, either.

jason0x43 commented 7 years ago

maximizeWindow has the same issue.

jason0x43 commented 7 years ago

After quite a bit of testing, it looks like the window control commands on FF are pretty borked for anything less than FF 55 + geckodriver 0.18.0 + Selenium 3.5.0. That configuration works well on BrowserStack, but is still fairly flakey on Sauce Labs. FF 55 + geckodriver 0.19.0 + Selenium 3.5.2 on my MacBook also seems fairly reliable.

jason0x43 commented 7 years ago

Actually, Sauce Labs doesn't work with Selenium 3.5.0, it only seems to work with Selenium 3.4.0 (+ FF 55 + whatever geckodriver they're using). Unfortunately, the window/rect bindings in Selenium 3.4.0 appear to be incomplete, in that GET window/rect doesn't return the full rect.

jason0x43 commented 7 years ago

Resolved with https://github.com/theintern/leadfoot/commit/1e8ad41f0a2a44c9150d6419201822d9a525f28b