search

theintern / leadfoot

A JavaScript client library that brings cross-platform consistency to the Selenium WebDriver API.
Other
170 stars 24 forks source link

Fix execute implemenatation #146

Closed cuff-links closed 6 years ago

cuff-links commented 6 years ago

Fixes #144 and #143

Since these entailed similar fixes I went ahead and made both fixes for the issues.

jason0x43 commented 6 years ago

Just out of curiosity, is there a particular need for these patches to be against Leadfoot 1.7.x vs master?

cuff-links commented 6 years ago

Not really. It was just that we use 1.7.5 so I started on that as my base.

On Sat, May 19, 2018, 10:27 PM Jason Cheatham notifications@github.com wrote:

Just out of curiosity, is there a particular need for these patches to be against Leadfoot 1.7.x vs master?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theintern/leadfoot/pull/146#issuecomment-390452996, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXaDn5ED6LdzIjWiYsOpj-7cf7upglPks5t0NSHgaJpZM4UFiom .

cuff-links commented 6 years ago

Hang on. We have some regressions on the type method. Debugging.

cuff-links commented 6 years ago

OK. This is fixed now.

cuff-links commented 6 years ago

Fixed #147

cuff-links commented 6 years ago

@jason0x43 I think we are looking good now. Please advise.

cuff-links commented 6 years ago

@jason0x43 We are good now.

cuff-links commented 6 years ago

@jason0x43 Anything else?

cuff-links commented 6 years ago

@jason0x43 Anything else here?

dylans commented 6 years ago

Please give us until early next week. Apologies for the delay @silne30

cuff-links commented 6 years ago

@dylans @jason0x43 ???

jason0x43 commented 6 years ago

@silne30 Sorry about that! Between vacation and work I lost track of this. I'll take care of it shortly.

cuff-links commented 6 years ago

Thanks! On Tue, Jul 17, 2018 at 1:17 PM Jason Cheatham notifications@github.com wrote:

@silne30 https://github.com/silne30 Sorry about that! Between vacation and work I lost track of this. I'll take care of it shortly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/theintern/leadfoot/pull/146#issuecomment-405658948, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXaDkcRhuSfdeNgNHgQYMbHRX2XHvY7ks5uHhwegaJpZM4UFiom .

jason0x43 commented 6 years ago

I restructured the commits a bit (combined them into three issues for type, execute, and getActiveElement) and merged it into 1.7. I'll do a 1.7.x release soon.