Added 2 options to Visual regression reporter

theintern / visual-plugin

Visual Regression Testing for Intern

Mozilla Public License 2.0

29 stars 7 forks source link

Added 2 options to Visual regression reporter #17

Open GARMBoshouwers opened 4 years ago

GARMBoshouwers commented 4 years ago

onlyReportErrors: Only display visual regressions in the report. Default option is false, so all tested screenshots are added to the report, which was the original system. When set to true, only reports that did not pass are added to the report, which makes it easier to find regressions by testers.
prefixTestName: Prefix the test name in the report with the parent test suite names. Default option is false, so the Comparison Header is the same as the original system. When set to true, the Comparison header is prefixed with the parent suite names to distinguish them in multi-suite runs.

jsf-clabot commented 4 years ago

All committers have signed the CLA.

GARMBoshouwers commented 4 years ago

Is there something more I have to do for that CLA? I clicked on the details of that check and agreed there as far as I can see, but it is still pending.

jason0x43 commented 4 years ago

Hmmm... there shouldn't be. I'll look into it.

jason0x43 commented 4 years ago

If you click the Details link now, does it tell you that you have signed the CLA?

GARMBoshouwers commented 4 years ago

First I get the form where I need to sign in with my GitHub credentials. If I do that, it says "You have signed the CLA for theintern/visual-plugin", so I assumed it should be correct.

GARMBoshouwers commented 4 years ago

Hmm, I did sign that agreement with my personal email, but I made the commit with my work account. These two adresses are both connected to my GitHub account. Could that be a problem?

jason0x43 commented 4 years ago

It's possible. Try updating the commit with your personal email and force-push.