search

theinvisible / openfortigui

VPN-GUI to connect to Fortigate-Hardware, based on openfortivpn
https://hadler.me/linux/openfortigui/
GNU General Public License v3.0
489 stars 54 forks source link

Optional credentials VPN config option #163

Closed dmlambea closed 1 year ago

dmlambea commented 2 years ago

Fixes #162

This PR makes the credentials (username/password) optional, so that for certificate-only VPN's the connecting procedure no longer asks for username/password.

dmlambea commented 1 year ago

Hi, @theinvisible

This PR has been here for a while now. Is there anything I can do to help you reviewing it? Thanks!

theinvisible commented 1 year ago

Hi, sorry for late answer. Can you check please if it still work in latest git source, thanks.

dmlambea commented 1 year ago

Hi, @theinvisible

I've just rebased the code onto your latest master and rebuilt my binary. I'm already connected to my company's VPN and it works flawlessly.

theinvisible commented 1 year ago

Have tested it now with our vpn profiles.

When there is both username and password set the connect failes because the modified if statement in vpnProcess::startVPN() empties now the given username/password. Can you fix this? Otherwise i will have a look...

dmlambea commented 1 year ago

@theinvisible you're right, the creds. were emptied every time the dialog wasn't to be shown, making a properly configured user/pass to be cleared out. The conflicting else part is now removed and it should work. I cannot fully test it because my VPN provider is certificate-only but I since get authentication failures when I enable it, I guess the credentials are being sent and it leads to the auth error.

I've rebased again onto your master branch. May you please check to see if it now works for you?

theinvisible commented 1 year ago

Thanks, looks good now and was merged.

Next stable release will include this changes.

dmlambea commented 1 year ago

Thank you very much, @theinvisible