search

theironrobin / siglo

GTK app to sync InfiniTime watch with PinePhone
Mozilla Public License 2.0
154 stars 21 forks source link

Add notification service #71

Closed Undef-a closed 3 years ago

Undef-a commented 3 years ago

This allows notifications to be sent from the standard application rather than only through the daemon. This version should be more stable as it includes the connection improvments of the main Siglo application.

Replaces #70 and relies on #64.

OrgansWithoutBodies commented 3 years ago

If this PR is open for comments, I think having the NotificationService loosely coupled with the DBus interpreter would be useful for easy future integration into notifications be extendible into custom notification interpreters

theironrobin commented 3 years ago

@Undef-a can these commits be pulled into the persist-pair branch of siglo instead of main?

When i tried pulling these commits into the persist-pair branch, it did indeed persist the pairing while the app was open, but the app crashed on an incoming text message, and no notification is displayed on the watch. :cry:

Reverted for now until we can get these commits compatible with persist-pair branch

theironrobin commented 3 years ago

notifications are now back and working in v0.9.0. the contributions in this PR helped me but i went in other directions just to get things in a working state. of course this can be improved upon so looking forward to seeing what we can come up with in the future.