search

theishiopian / Parrying

A mod about deflecting blows (and inflicting your own)
6 stars 5 forks source link

parry this weapons accept sweeping edge even when it doesn't make sense #23

Closed esotericist closed 2 years ago

esotericist commented 2 years ago

version 2.3, on forge 1.18.1-39.0.10

noticed this while looking at enchantment options for a spear, realized it also applied to the rest of the parry this weapons.

is it possible to limit sweeping edge applicability to just parry this weapons that it works on (just the flail, i think?)

k1r0s commented 2 years ago

By default all weapon enchantments are applied to parrythis weapons. It might be a bug since sweeping edge can only be applied to swords. This is a no op and should be removed.

theishiopian commented 2 years ago

Minecraft, by default, has only one kind of "weapon", as such anything considered a weapon can take weapon enchants. I've been slowly working on this, but it's like playing whack-a-mole

theishiopian commented 2 years ago

Should be fixed with latest commit