search

theishiopian / Parrying

A mod about deflecting blows (and inflicting your own)
6 stars 5 forks source link

Added tag registration check. #28

Closed AHilyard closed 2 years ago

AHilyard commented 2 years ago

This should fix #21. Basically it just makes sure that the TWO_HANDED_WEAPONS tag is bound before accessing it.

Kaleidio commented 2 years ago

[deleted as I got confused lol]

theishiopian commented 2 years ago

Man, I searched SO LONG for how to do that, found nothing. Got to the point where i wasn't even sure it was a thing. Thanks!

theishiopian commented 2 years ago

Instead of merging, I am going to implement this directly into main. I will add your name to the credits, unless you dont want it there.

Kaleidio commented 2 years ago

will this be getting a 1.16.5 release for sure?

AHilyard commented 2 years ago

Man, I searched SO LONG for how to do that, found nothing. Got to the point where i wasn't even sure it was a thing. Thanks!

No problem! Luckily I've had to fix a very similar bug before so I knew where to look. I don't mind my name in the credits, thanks! 😄

theishiopian commented 2 years ago

ok, so new problem. the code you provided does not work on 1.18.2. the Method ItemTags.getTags no longer exists, and I cannot find a suitable replacement.

theishiopian commented 2 years ago

I am going to push on for now, lmk if you find anything for 1.18.2, though it sounds like the issue may not appear on newer versions anyways.

theishiopian commented 2 years ago

will this be getting a 1.16.5 release for sure?

1.16.5 is no longer supported by me. It is simply too much work to support older versions. however, if you want to compile a build from your branch, I would be willing to put it up. You would be credited of course, and I'd be willing to add you as a contributor on curse as well.

AHilyard commented 2 years ago

will this be getting a 1.16.5 release for sure?

1.16.5 is no longer supported by me. It is simply too much work to support older versions. however, if you want to compile a build from your branch, I would be willing to put it up. You would be credited of course, and I'd be willing to add you as a contributor on curse as well.

Sure thing, I still have the code available to compile here. Should I use a version of 2.2.3 or something else?

theishiopian commented 2 years ago

call it something like 2.2.2a or 2.2.2TagFix, just to make clear its unofficial.

theishiopian commented 2 years ago

oh, and feel free to add yourself to the credits, ive already added you to the credits in the main branch

AHilyard commented 2 years ago

I am going to push on for now, lmk if you find anything for 1.18.2, though it sounds like the issue may not appear on newer versions anyways.

Okay, if it does turn out to be necessary the 1.18.2 equivalent is Registry.ITEM.isKnownTagName(ModTags.TWO_HANDED_WEAPONS).

theishiopian commented 2 years ago

Awesome, ill add that

AHilyard commented 2 years ago

call it something like 2.2.2a or 2.2.2TagFix, just to make clear its unofficial.

Okay, here you go! parrying-2.2.2a.zip

theishiopian commented 2 years ago

ill take a look very soon, thank you so much for your efforts

AHilyard commented 2 years ago

No problem, glad to be of help. 😄

theishiopian commented 2 years ago

Message me on curse if you want to be added to the project as a contributor. You wouldnt have to do anything, it would just make your involvement more known.