Closed WeilerP closed 3 years ago
It installs all the necessary things - tox
and pre-commit (the latter is just for convenience of not running tox -e lint
), think it's fine as it is.
It installs all the necessary things -
tox
and pre-commit (the latter is just for convenience of not runningtox -e lint
), think it's fine as it is.
Running
pip install -e '.[dev]'
pre-commit install
tox -e py38-linux
failed for me since, e.g., pytest
wasn't installed.
Thanks for catching this, indeed, the required packages are not listed in tox.ini
, will fix it soon.
Thanks for catching this, indeed, the required packages are not listed in tox.ini, will fix it soon.
Hmm, upon further inspection, it seems correct, the test
requirements are still in setup.py
and also used in tox.ini
. Furthermore, I wasn't able to reproduce this or the warning in #627 (let's move the discussion here).
@Marius1311 can you reproduce this on your Mac?
I'll check this out, however, it's a bit tight before the release - I'll look into it afterwards, we can exclude this from the release.
Is this still an issue?
Is this still an issue?
Did you try locally on your machine with a fresh conda environment whether you get the same issues as mentioned above? If yes, let's discuss tomorrow.
I tried:
pip install -e '.[dev]'
pre-commit install
tox
See below for the output I got. Is this what you guys wanted me to run?
@michalk8, I reinstalled the developer installation in a fresh charliecloud container and ran into an issue when running the unit tests the first time. I first installed all the necessary packages in a clean conda environment, i.e.
pip install -e '.[dev, external, test]'
apt-get install libopenmpi-dev
pip install --user mpi4py
pip install --user petsc
pip install --user petsc4py
pip install --user slepc
pip install --user slepc4py
and then ran
tox -e py38-linux
which threw an error caused by petsc/slepc.
Running the tests again via
tox -e py38-linux
worked fine but I still see the deprecation warning mentioned in #627. Any idea on what went wrong?
Based on the log, this seems to be a problem:
/usr/bin/python2 is missing "distutils.sysconfig" module! Its required to build PETSc
Try installing (for ex: on Ubuntu) "python3-distutils" or equivalent package that is compatible with /usr/bin/python2
Maybe sudo apt-get install python3-distutils
will help? Tbh, not sure why is it trying to look-up python2
(esp. in /usr/bin
).
Re the warning: this is because pytest
is also globally installed (via [test]
external requirements). Can be fixed via python -m pytest ...
in tox.ini
.
Also, could you please post the Dockerfile you're using on MM? I want to take a look to see if all dependencies are there.
The warning should be fixed by 395bdcc, going to try devel install on the server now.
@WeilerP can't reproduce the error using my container, running dpkg --list | grep python3-distutis
shows that I have it installed, so installing it should fix the issue.
@WeilerP, can you share your container with @michalk8 so he can reproduce this? Or what's our solution for this?
@WeilerP can't reproduce the error using my container, running
dpkg --list | grep python3-distutis
shows that I have it installed, so installing it should fix the issue.
Sorry, forgot to answer. python3-distutils
is installed. Is it a problem that I am using Python 3.8 but python3-distutils
is Python 3.7.3? Or should I check that it is installed in a new container?
@WeilerP, can you share your container with @michalk8 so he can reproduce this? Or what's our solution for this?
Yes, can share the container but not sure if it is worth the effort. What do you think @michalk8?
I can run the tests it just doesn't work out of the box for me. I just gotta run tox -e py38-linux
at least twice (the first run fails, all following run the tests).
Sorry, forgot to answer. python3-distutils is installed. Is it a problem that I am using Python 3.8 but python3-distutils is Python 3.7.3? Or should I check that it is installed in a new container?
That might be a problem, so I'd check.
Yes, can share the container but not sure if it is worth the effort. What do you think @michalk8?
I'd say not worth the effort - ideally, I'd like to close this soon.
@michalk8, everything seems to work after upgrading python3-distutils
to 3.7.3
.
Description
Running
pip install -e '.[dev]'
does not install all packages required for a full development cycle. For example, any modules related to testing are not installed. IMO, a developer installation should allow running the entire codebase as well as unit tests without having to install additional libraries. What do you think @Marius1311, @michalk8?