Closed WeilerP closed 2 years ago
This might've happened when the notebook was automatically regenerated (the better case) or we changed the defaults and this caused the issue.
I used to get the plot below:
The random walks also used to look slighly different - which change could have caused this @michalk8?
In line 10, we fix most of the relevant parameters: ctk.compute_transition_matrix(threshold_scheme="soft", nu=0.5)
This cannot yet be caused by https://github.com/theislab/cellrank/pull/778, right?
This cannot yet be caused by #778, right?
No, it cannot.
@WeilerP volunteered to check what caused this change. Thanks @WeilerP!
@michalk8, the proposed eigengap switches from 3 to 5 when applying this commit, i.e. after merging #583. I presume it is due to the changes to Pseudotimekernel.compute_transition_matrix
. Specifying b=20
indentifies the gap after 4 eigenvalues. What was the reason for removing percentile
and density_normalize
as function arguments?
@michalk8, the proposed eigengap switches from 3 to 5 when applying this commit, i.e. after merging #583. I presume it is due to the changes to Pseudotimekernel.compute_transition_matrix. Specifying b=20 indentifies the gap after 4 eigenvalues. What was the reason for removing percentile and density_normalize as function arguments?
We've had the internal finetuning of these on Zebrafish + other dataset (also linked in the PR, should be visible for you) and it did perform slightly worse.
Yes, but why not simply use default values (density_normalize=False
, percentile=None
) to allow for more flexibility?
@WeilerP, would you mind checking whether this is due to density_normalize
, percentile
, or both of them? I recall percentile
just didn't make much sense to me intuitively, that's why we removed it (also, it didn't give better performance, as @michalk8 stated above).
Hello CellRank,
This is also what I'm curious about. If the dash line is at Index '4', how many n_states
shall we set for g_fwd.compute_macrostates(n_states=?)
, 4 or 5?
Thanks!
Best
YJ
In the example below, the eigengap would be inferred aver 5 eigenvalues, so you should compute 5 macrostates, as a starting point. Keep in mind the eigengap statistic is a heuristic though, so take this more as a starting point to your analysis.
@Marius1311, @michalk8, is there a reason why we start counting the eigenvalues at 0? I always found this rather confusing, TBH.
Not that I recall - happy to change this so that we start counting with 1.
Description
The Schur decomposition in the CytoTRACE tutorial here highlights an eigengap after
5
eigenvalues.The following text, however, talks about an eigengap after
3
eigenvalues which is supposedly shown in the figure. Am I missing something or do we need to update this @Marius1311, @michalk8?