search

theislab / diffxpy

Differential expression analysis for single-cell RNA-seq data.
https://diffxpy.rtfd.io
BSD 3-Clause "New" or "Revised" License
191 stars 23 forks source link

Preparing v0.8 #218

Open ilan-gold opened 2 years ago

ilan-gold commented 2 years ago

Pairs with https://github.com/theislab/batchglm/pull/146

This PR aims to upgrade batchglm. The main outstanding question mentioned on slack is whether the 5 failing tests in test_constrained.py and test_pairwise_null.py should be deleted. It seems to me that they are trying to do the impossible by fitting more than one scale parameter but I feel somewhat uncertain here because I have had trouble with constraints before and I am not familiar with Z-tests. Other than that, feel free to ask why I did anything!

davidsebfischer commented 2 years ago

Can I rebase this branch to dev? Just so that we can merge through there. Once both this and the corresponding PR on batchglm are in the respective dev branches, I would then advance them to release, incremementing the dependency version of batchglm in diffxpy as well.

ilan-gold commented 2 years ago

Ah yes of course! I was wondering what was up with that - it seems like master is ahead of dev?

davidsebfischer commented 2 years ago

Ah yes of course! I was wondering what was up with that - it seems like master is ahead of dev?

Those were small fixes it seems, I rebased them into dev. I think the rebase caused two minor conflicts, as shown in the summary of the PR.