theislab / ehrapy

Electronic Health Record Analysis with Python.
https://ehrapy.readthedocs.io/
Apache License 2.0
214 stars 19 forks source link

Harmonize miss_forest and mice_forest imputation function names #370

Closed Zethson closed 2 years ago

Zethson commented 2 years ago

Currently one has an underscore and the other does not.

xinyuejohn commented 2 years ago

I think in data_imputation.py, it is called miceforest_impute and miss_forest_impute.

Zethson commented 2 years ago

Yeah. I was thinking that they should be called.

mice_forest_impute and miss_forest_impute

miceforest_impute and missforest_impute

Likely the former. Don't worry :)