add functools.wraps to type check

theislab / ehrapy

Electronic Health Record Analysis with Python.

https://ehrapy.readthedocs.io/

Apache License 2.0

232 stars 19 forks source link

add functools.wraps to type check #705

Closed eroell closed 6 months ago

eroell commented 6 months ago

PR Checklist

[x] This comment contains a description of changes (with reason)
[ ] Referenced issue is linked none
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] Documentation in docs is updated

Description of changes Wrappers can cause the function docstring to be lost: functools.wraps can solve that

Currently have that e.g. here.

Technical details

Additional context

eroell commented 6 months ago

@Lilly-May if you got a second to double-check that decorated functions now look too as they should, would be awesome :)

Lilly-May commented 6 months ago

I reviewed the documentation for all methods to which the check_feature_types decorator was added, and everything looks fine to me. So, I believe we should be good to merge!

Zethson commented 6 months ago

I'll fix the CI!