search

theislab / ehrapy

Electronic Health Record Analysis with Python.
https://ehrapy.readthedocs.io/
Apache License 2.0
235 stars 19 forks source link

Make download part of ehrdata #817

Open eroell opened 2 weeks ago

eroell commented 2 weeks ago

Description of feature

The _dataloader module is currently private. Should we make it be part of the public API? It is useful for downloading datasets, and could also be so for other developers.

The least reduces redundancy for us, without us using private modules across repos

https://github.com/theislab/ehrapy/blob/0a74f705650e71485de44d5054cd7145e27c4d62/ehrapy/data/_dataloader.py#L17

Zethson commented 2 weeks ago

I could see it become a part of ehrdata and ehrapy depend on ehrdata. WDYT?

eroell commented 2 weeks ago

Sounds good to me :+1: