Closed selmanozleyen closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.19%. Comparing base (
3151da7
) to head (f3c54be
). Report is 25 commits behind head on main.:exclamation: Current head f3c54be differs from pull request most recent head b054584
Please upload reports for the commit b054584 to get more accurate results.
in the failing tests, set tau_a, tau_b > 0.5
I tried all of your suggestions and it only worked when I set the tau's to be 1.0 which is balanced. I checked again and it fails after this https://github.com/ott-jax/ott/commit/41906a2a1ade19aa154189fabd7c159a160c9bf3 commit specifically. I created a PR separately for the setting the defaults to None https://github.com/theislab/moscot/pull/686
ok then i think we need to raise this to @michalk8 because it is not expected
agree, can you maybe try to run the example without moscot, but directly with ott-jax @selmanozleyen ? This might help @michalk8
agree, can you maybe try to run the example without moscot, but directly with ott-jax @selmanozleyen ? This might help @michalk8
@MUCDK ok I created it here https://github.com/ott-jax/ott/issues/519
Here are the steps I planned. I first want to ensure the tests work with this version and I am currently on that step.
In order to comply to new version: