Fix: CI examples not throwing error from some commands

theislab / moscot

Multi-omic single-cell optimal transport tools

https://moscot-tools.org

BSD 3-Clause "New" or "Revised" License

112 stars 9 forks source link

Fix: CI examples not throwing error from some commands #713

Closed selmanozleyen closed 3 months ago

selmanozleyen commented 3 months ago

Here is an example case where it throws error but the CI still doesn't fail. This PR will fix that issue

The script run is now a separate file
I also added tutorials folder to the list of notebooks to execute
added the dependencies to add the tutorials folder

It is ready for review. Once the notebooks are updated it is ready for merge imo

MUCDK commented 3 months ago

Amazing, thanks @selmanozleyen ! @ArinaDanilina , please update the notebooks accordingly!

giovp commented 3 months ago

I think the tutorial folder is a bit excessive, and examples should be fine?

selmanozleyen commented 3 months ago

So should I remove the tutorials folder? There are notebooks that fail there.

MUCDK commented 3 months ago

I think tutorials is too much, especially once we replace them with larger data. Then CI would just take for too long. Let's rather have them checked manually regularly