Open SabrinaRichter opened 2 years ago
Hi @SabrinaRichter,
It looks like this pull-request is has been made against the theislab/ncem master
or main
branch.
The master
/main
branch should always contain code from the latest release.
Because of this, PRs to master
/main
are only allowed if they come from any theislab/ncem release
or patch
branch.
You do not need to close this PR, you can change the target branch to development
by clicking the "Edit" button at the top of this page.
Thanks again for your contribution!
@AnnaChristina the supervised manuscript works on binary cell types for schuerch (https://github.com/theislab/tissue/blob/b53bcd6bbeefb10f2930fc5c55e51d6d4cfefa4c/tissue/data.py#L1641) any idea how you want different coarseness levels being handled? multiple cluster_col_xxx columns and then optionally selecting another cluster_col for node_type one-hot encoding set to 'cluster_col_preprocessed' by default?
I would define this as an additional column in obs of celldata, and I'll check how we ensure this is then subsequently used.
Yes would also go for the set default als many plotting function in ncem require the preprocessed cell names
see my edit above?
Yes also just edited!
Can you check out the latest commit? should not have any effect on your code. currently only one level is saved in obs, but one can select which one in the init method
Looks good to me.
PR Checklist
docs
is updatedDescription of changes
Technical details
Additional context