search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Refactor metrics #256

Closed mumichae closed 3 years ago

mumichae commented 3 years ago

Split huge metrics file into several modules

LuckyMD commented 3 years ago

Hey @mbuttner! Thanks for the review of this. Would you mind adding the lisi and kbet documentation that you mentioned was missing? @mumichae only reorganized the code that was already there into separate files. These aspects you highlighted are important, but they were already missing before as well. We might need everyone who wrote the functions to do the documentation for them. @mumichae can test via the pipeline again at the end. Might be good to do a PR to this branch for that though.

mumichae commented 3 years ago

We need codecov ideally ^^. Difficult to judge otherwise. Did you run the pipeline test with this to ensure all metrics are still callable as before? Also kBET and LISI?

I can confirm that the pipeline runs through and the results don't change compared to master.

mumichae commented 3 years ago

@mbuttner @LuckyMD I'd consider this PR to be ready to merge. I'll open a new PR for cleaning up and updating docstrings.

LuckyMD commented 3 years ago

Thanks @mumichae !