search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Check kbet lisi #264

Closed mbuttner closed 3 years ago

mbuttner commented 3 years ago

Looking good so far. I think we could be more radical in removing never used parameters and comments. Are changes for the LISI functions also planned?

Thanks, I checked the LISI functions and did not find things that I would change.

mumichae commented 3 years ago

OK, then I would cleanup the code, which shouldn't change the score. That'll be subject to a new PR.

mbuttner commented 3 years ago

Awesome, thank you!