search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Update dependency versions #294

Closed mumichae closed 2 years ago

mumichae commented 2 years ago

Remove version pins for numpy and h5py as requested in #283

mumichae commented 2 years ago

For some reason Github actions is returning NMI scores slightly larger than 1 during testing. I couldn't reproduce this error offline.

    def test_nmi_trivial(adata):
        score = scib.me.nmi(adata, 'celltype', 'celltype')
>       assert score == 1
E       assert 1.0000000000000002 == 1
E         +1.0000000000000002
E         -1
Zethson commented 2 years ago

Great, thank you! We'd also require a swift PyPI release after this PR is merged.