theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Use pre-commit #305

Closed mumichae closed 2 years ago

mumichae commented 2 years ago

Start using pre-commit

Suggestions from @michalk8 :

  • [x] remove 3.7 CI, add 3.9 (unless you need to support it)
  • [x] use pre-commits (add e.g. black) instead of running raw flake8 (this PR was)
  • [x] add tests coverage
  • [x] not sure how much work, but macOS test CI would be nice to have

with emphasis on the first 2 points

Notes:

michalk8 commented 2 years ago

I'd also recommend purging large files (most likely .ipynb) from the git repo history. When I cloned this repo, I downloaded like 300MiB of data, see also https://rtyley.github.io/bfg-repo-cleaner/.

LuckyMD commented 2 years ago

Fully agree! .ipynb files should be moved to scib-reproducibility... I thought that already happened mostly. Thanks @michalk8

lazappi commented 2 years ago

All the files have been moved but they are still in the git history which gets downloaded when the repository is cloned. They would need to be purged from the history as suggested to stop this happening.

mumichae commented 2 years ago

Cleaning the blobs will rewrite the git history, which could break current open pull requests. I'd do this once we have merged some of the recent PRs