search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Fix scanvi bug #327

Closed mumichae closed 2 years ago

mumichae commented 2 years ago

Addresses #324 and https://github.com/theislab/scib-pipeline/issues/41

codecov[bot] commented 2 years ago

Codecov Report

Merging #327 (b0aefb6) into main (ad40b62) will increase coverage by 1.54%. The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   55.16%   56.70%   +1.54%     
==========================================
  Files          36       38       +2     
  Lines        1967     1984      +17     
==========================================
+ Hits         1085     1125      +40     
+ Misses        882      859      -23
Flag Coverage Δ
unittest 56.70% <91.30%> (+1.54%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scib/integration.py 34.33% <77.77%> (+15.31%) :arrow_up:
tests/integration/test_scanvi.py 100.00% <100.00%> (ø)
tests/integration/test_scvi.py 100.00% <100.00%> (ø)
mumichae commented 2 years ago

I do test the integration methods, but in a separate step, so it runs in parallel and also updates the code coverage

LuckyMD commented 2 years ago

okay, cool! Didn't see the separate test in this PR, but I guess it's there from before :).