search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Fix batch silhouette bug #342

Closed mumichae closed 1 year ago

mumichae commented 1 year ago

closes #330

codecov[bot] commented 1 year ago

Codecov Report

Merging #342 (d162b2c) into main (6ae3b80) will increase coverage by 0.33%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ========================================== + Coverage 54.76% 55.09% +0.33% ========================================== Files 38 38 Lines 2027 2040 +13 ========================================== + Hits 1110 1124 +14 + Misses 917 916 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittest | `55.09% <100.00%> (+0.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/theislab/scib/pull/342?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | Coverage Δ | | |---|---|---| | [scib/metrics/silhouette.py](https://codecov.io/gh/theislab/scib/pull/342/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-c2NpYi9tZXRyaWNzL3NpbGhvdWV0dGUucHk=) | `83.78% <100.00%> (+4.99%)` | :arrow_up: | | [tests/metrics/test\_silhouette\_metrics.py](https://codecov.io/gh/theislab/scib/pull/342/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-dGVzdHMvbWV0cmljcy90ZXN0X3NpbGhvdWV0dGVfbWV0cmljcy5weQ==) | `100.00% <100.00%> (ø)` | |