theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Update louvain to 0.8 #346

Closed scottgigante-immunai closed 1 year ago

scottgigante-immunai commented 1 year ago

A new version of louvain has been released after quite some time. This PR updates scIB to use the new version, unpinning igraph.

scottgigante-immunai commented 1 year ago

Codecov is failing, recommend you switch to the Codecov Action with repo token as we did for openproblems

codecov[bot] commented 1 year ago

Codecov Report

Merging #346 (902bba5) into main (ddf1c9e) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #346 +/- ## ======================================= Coverage 59.53% 59.53% ======================================= Files 39 39 Lines 2123 2123 ======================================= Hits 1264 1264 Misses 859 859 ``` | Flag | Coverage Δ | | |---|---|---| | unittest | `59.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#carryforward-flags-in-the-pull-request-comment) to find out more.
mumichae commented 1 year ago

Thanks @scottgigante-immunai for the update! I haven't quite found out how to use the Codecov Action with a matrix and will address it in a separate PR

scottgigante-immunai commented 1 year ago

Thanks @mumichae ! I recommend you check out https://github.com/openproblems-bio/openproblems/pull/707/files