search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
294 stars 63 forks source link

Fix kBET import issue #350

Closed mumichae closed 1 year ago

mumichae commented 1 year ago

Closes #349 Closes #270

codecov[bot] commented 1 year ago

Codecov Report

Merging #350 (18d231a) into main (e028e04) will increase coverage by 3.08%. The diff coverage is 42.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #350 +/- ## ========================================== + Coverage 56.45% 59.53% +3.08% ========================================== Files 39 39 Lines 2122 2123 +1 ========================================== + Hits 1198 1264 +66 + Misses 924 859 -65 ``` | Flag | Coverage Δ | | |---|---|---| | unittest | `59.53% <42.85%> (+3.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/theislab/scib/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | Coverage Δ | | |---|---|---| | [scib/metrics/kbet.py](https://codecov.io/gh/theislab/scib/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-c2NpYi9tZXRyaWNzL2tiZXQucHk=) | `71.96% <0.00%> (+51.40%)` | :arrow_up: | | [scib/exceptions.py](https://codecov.io/gh/theislab/scib/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-c2NpYi9leGNlcHRpb25zLnB5) | `40.00% <33.33%> (-10.00%)` | :arrow_down: | | [tests/metrics/rpy2/test\_kbet.py](https://codecov.io/gh/theislab/scib/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-dGVzdHMvbWV0cmljcy9ycHkyL3Rlc3Rfa2JldC5weQ==) | `100.00% <100.00%> (ø)` | | | [scib/metrics/utils.py](https://codecov.io/gh/theislab/scib/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-c2NpYi9tZXRyaWNzL3V0aWxzLnB5) | `33.82% <0.00%> (+17.64%)` | :arrow_up: |
lazappi commented 1 year ago

It's probably better to use {remotes} to install stuff rather than {devtools}. It has much fewer dependencies so it will make things faster.

mumichae commented 1 year ago

It's probably better to use {remotes} to install stuff rather than {devtools}. It has much fewer dependencies so it will make things faster.

Thanks, that'll make things much easier!