search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
283 stars 62 forks source link

Add perfect isolabel ASW test #362

Closed mumichae closed 1 year ago

mumichae commented 1 year ago

closes #359

codecov[bot] commented 1 year ago

Codecov Report

Merging #362 (6f54d57) into main (896f689) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #362 +/- ## ======================================= Coverage 53.13% 53.13% ======================================= Files 22 22 Lines 1848 1848 ======================================= Hits 982 982 Misses 866 866 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `53.13% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#carryforward-flags-in-the-pull-request-comment) to find out more.
LuckyMD commented 1 year ago

This works here?... very strange as it doesn't in open problems... but thanks!

danielStrobl commented 1 year ago

Just looking over this as this doesn't seem to work in openproblems, this is testing the perfect baseline for iso label f1 and not iso label asw if I read the code correctly?