theislab / scib

Benchmarking analysis of data integration tools
MIT License
311 stars 63 forks source link

Refactor LISI metrics #395

Closed mumichae closed 7 months ago

mumichae commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.97%. Comparing base (59ae6ee) to head (824c146).

:exclamation: Current head 824c146 differs from pull request most recent head fa77b53. Consider uploading reports for the commit fa77b53 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #395 +/- ## ========================================== + Coverage 52.81% 57.97% +5.15% ========================================== Files 22 22 Lines 1882 1675 -207 ========================================== - Hits 994 971 -23 + Misses 888 704 -184 ``` | [Flag](https://app.codecov.io/gh/theislab/scib/pull/395/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/theislab/scib/pull/395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | `57.97% <80.55%> (+5.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/theislab/scib/pull/395?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | Coverage Δ | | |---|---|---| | [scib/metrics/lisi.py](https://app.codecov.io/gh/theislab/scib/pull/395?src=pr&el=tree&filepath=scib%2Fmetrics%2Flisi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-c2NpYi9tZXRyaWNzL2xpc2kucHk=) | `80.47% <80.55%> (+38.18%)` | :arrow_up: |