search

theislab / scib

Benchmarking analysis of data integration tools
MIT License
311 stars 63 forks source link

Use precomputed clustering #406

Closed mumichae closed 7 months ago

mumichae commented 7 months ago

Improve performance of clustering function to reduce redundant kNN and clustering operations

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.16%. Comparing base (127e41e) to head (2b3230d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #406 +/- ## ========================================== + Coverage 57.85% 58.16% +0.31% ========================================== Files 22 22 Lines 1675 1683 +8 ========================================== + Hits 969 979 +10 + Misses 706 704 -2 ``` | [Flag](https://app.codecov.io/gh/theislab/scib/pull/406/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/theislab/scib/pull/406/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | `58.16% <96.96%> (+0.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/theislab/scib/pull/406?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab) | Coverage Δ | | |---|---|---| | [scib/metrics/isolated\_labels.py](https://app.codecov.io/gh/theislab/scib/pull/406?src=pr&el=tree&filepath=scib%2Fmetrics%2Fisolated_labels.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-c2NpYi9tZXRyaWNzL2lzb2xhdGVkX2xhYmVscy5weQ==) | `93.65% <100.00%> (+0.66%)` | :arrow_up: | | [scib/metrics/clustering.py](https://app.codecov.io/gh/theislab/scib/pull/406?src=pr&el=tree&filepath=scib%2Fmetrics%2Fclustering.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theislab#diff-c2NpYi9tZXRyaWNzL2NsdXN0ZXJpbmcucHk=) | `88.34% <96.15%> (+2.21%)` | :arrow_up: |