theislab / scvelo

RNA Velocity generalized through dynamical modeling

https://scvelo.org

BSD 3-Clause "New" or "Revised" License

412 stars 102 forks source link

Fix/compute_neighbors, issue #1212 #1229

Closed Abelgurung closed 5 months ago

Abelgurung commented 6 months ago

1212

scv.pp.moments(adata, n_pcs= int , n_neighbors= int )

Returns: TypeError: Neighbors.compute_neighbors() got an unexpected keyword argument 'write_knn_indices'

The argument write_knn_indices was deprecated in a previous commit (see scanpy commit 1fd6c46)

Removing 'write_knn_indices' arg from the compute_neighbors method call within scv.pp.moments does not seem to affect downstream analysis Lmk what you think @WeilerP

WeilerP commented 5 months ago

Thanks, @Abelgurung. I'm closing this PR in favor of #1233. Please use the provided template and check unit tests locally when submitting a PR next time.