search

thej022214 / OUwie

Estimates and compares rate differences of continuous character evolution under Brownian motion and a new set of Ornstein-Uhlenbeck (OU) models that allow the strength of selection and drift to vary across selective regimes.
9 stars 3 forks source link

Fixed lower and upper bound in OUwie search #12

Closed Caetanods closed 3 years ago

Caetanods commented 3 years ago

Minor detail that does not influence the method performance. Hey @jboyko ! The lower and upper bounds are fixed for Ouwie. The current code in the branch has the lb and up arguments, but these arguments are not in the call for the function in the RCran version 2.5 . If you try to specify the bounds using the opts argument, it will not be passed to nloptr.

jboyko commented 3 years ago

I believe this is fixed on the latest version! It will be released to the masses shortly.

User input first enters code: https://github.com/thej022214/OUwie/blob/3339416fa3436185fdbe81a61f017ce388fc7d68/R/OUwie.R#L438

~ some modifications ~

User input enters nloptr: https://github.com/thej022214/OUwie/blob/3339416fa3436185fdbe81a61f017ce388fc7d68/R/OUwie.R#L497

Caetanods commented 3 years ago

Awesome! Thanks.