These are some optimizations I made that have been working well for me. I wanted to contribute them back to the project.
I minimized the number of Dockerfile instructions. There is now just one ENV and one RUN instruction each. I also found that there wasn't a need to build packages from source. There are apk packages that work. I also removed the pip install instruction because there is an apk package that works for this. I moved the chmod and apk install commands into the same instruction to simplify things.
I updated entry.sh to use bashio, which eliminated the need to install the jq package. I also updated the log output to hash the password. I don't think plain text passwords in any log are a good idea. Having it hashed still gives confirmation that a password was configured.
p.s. Just wanted to say thanks for starting this project. It's been a lot of fun experimenting with it.
thejeffreystone
commented
1 year ago
Hello,
These are some optimizations I made that have been working well for me. I wanted to contribute them back to the project. I minimized the number of Dockerfile instructions. There is now just one ENV and one RUN instruction each. I also found that there wasn't a need to build packages from source. There are apk packages that work. I also removed the pip install instruction because there is an apk package that works for this. I moved the chmod and apk install commands into the same instruction to simplify things.
I updated entry.sh to use bashio, which eliminated the need to install the jq package. I also updated the log output to hash the password. I don't think plain text passwords in any log are a good idea. Having it hashed still gives confirmation that a password was configured.
p.s. Just wanted to say thanks for starting this project. It's been a lot of fun experimenting with it.