thejoshwolfe / legend-of-swarkland

Turn-based action fantasy puzzle game inspired by NetHack and Crypt of the Necrodancer
http://wolfesoftware.com/legend-of-swarkland/
Other
91 stars 5 forks source link

override build mode of SDL2 dependency to ReleaseFast #62

Closed andrewrk closed 4 years ago

andrewrk commented 4 years ago

with ziglang/zig#3570 merged into zig, SDL2 built in debug mode trips undefined behavior sanitization. Since this project is not SDL2 itself and is rather using SDL2 as a dependency, we avoid this by overriding the build mode of the SDL2 dependency to be always ReleaseFast.

This has the additional benefit of making debug builds of legend-of-swarkland more viable, since "hot paths" which include SDL2 function calls are now using optimized SDL2 builds.

This pull request depends on #61