search

thejoshwolfe / yauzl

yet another unzip library for node
MIT License
737 stars 80 forks source link

Allow Zip64 files to have 0xffff as "number of this disk" in eocdr #118

Closed rossj closed 9 months ago

rossj commented 4 years ago

I've come across a number of single-disk Zip64 files that have 0xffff as values for the "number of this disk" and the "number of the disk with the start of the central directory" in the standard eocdr, with the correct override values being present in the Zip64 eocdr.

This PR updates yauzl to handle these files, by only throwing if the standard disk count value is > 0 and < 0xffff, and adds an additional check on the zip64 disk count value.

Technically, this update would prevent yauzl from erroring on a multi-disk, non-zip64 file that actually has 0xffff parts / disks, but that would be one very contrived file.

thejoshwolfe commented 9 months ago

This should be fixed in yauzl version 3.1.1