search

thekabal / tki

The Kabal Invasion - A web based space exploration (4x) game
Other
11 stars 7 forks source link

Tighten up the .gitignore file #14

Closed jakecleary closed 8 years ago

jakecleary commented 8 years ago

This will stop random stuff getting committed.

Most notably I’ve added the .idea directory, which will stop contributors’ copies of PHPStorm from adding a bunch of meta files into the repo.

Let's wait until we decide what to do with the develop branch before we merge this.

thekabal commented 8 years ago

I did merge this, but after testing with Sensio labs, it flagged a bunch of .gitignore stuff as things that are user specific:

/.idea is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

And similar for the other items I removed. I agree with Sensio - add it to your user global gitignore.

https://insight.sensiolabs.com/projects/f911af82-50d9-4a37-b1bb-6ad929d18245/analyses/76

jakecleary commented 8 years ago

Hey @thekabal,

I agree that these are personal things, however I've found that it's generally easier to add common ones into the project for ease of contribution, as it's quite common for people to not pay attention and accidentally commit files into their PRs. If you'd like to remove them I'd understand though 👍