thekabal
commented
8 years ago Hello!
Thanks for asking! (Why have you always stayed away from GitHub?)
Awesome to hear that you worked on the code base, its always nice to work with other devs that are familiar with it. I'd welcome PR's at first for targetted work, and if that works out after a few weeks, we can definitely get you contributing!
I am (as I suspect you can see from my recent commits) extremely dedicated to bring the code up to modern standards, but I also intend some fairly massive changes in game play. Originally the BNT-Advanced codebase (Which was TKI before that) included lots of crazy things, like:
- Spies & Diplomats
- True Spiral arm galaxy
- Variable star sizes leading to variable # of planets allowed in a given system
And so forth. Once I get the Adodb->PDO transition done, the next steps look like:
- Cover most of the major issues identified by SensioLabs & Scrutinizer
- Languages - no more hard coded strings anywhere but in the languages system
- Template conversion - Migrate 100% of pages to be template driven
Those are the really major "blockers". Once those are done, I'll be switching gears to re-merging the BNTA/TKI original features like multiple ship classes, spies, etc.
I'm very supportive of adding additional themes to the game, so that sounds fairly awesome. I think it would be easier if we get the template conversion done before that, but I'm not saying no!
As for the framework migration, I suspect you'd be better off trying to accomplish that in a fork. I see a few areas (router, DIC, http requests, security) where a framework would be nice. However, right now, I'd probably choose Symfony, and that wouldn't even begin until all of the major projects above are done. I'm also deeply opposed to huge numbers of dependencies.
That said, I think there is plenty we do both plan to accomplish, so if you can be patient on some of the other items, we should be able to work together on it!
You can also reach me at thekabal @ gmail.com
urbndecay
Hey there. Sorry if this isn't the best way to get in touch with people involved in the project. I've used git/svn for years but always stayed away from Github.
So I worked on the BNT code base years ago, and spent several months working with it. I picked up the project again after years of being idle and saw that you have started all the much needed updates to the code base.
I wanted to find out what your plans are with this project so I can know if its best to just fork it, or commit directly to the project.
Are you planning on just updating the code base to modern standards and continue having the game be as is (matching the mechanics of TW2002) or are you looking to enhance the game and adding new functionality and features?
My plans were to continue on the overhaul of the codebase, adding a new theme (bootstrap based) and then either beginning new features and game play, or maybe doing a migration to a PHP based framework, specifically I was thinking CodeIgniter.
If our long term interests don't mash up then I can always fork, but if there is fun stuff to work together on I'd prefer to not deal with forking/pulling until it was needed.