thekevinscott / UpscalerJS

Enhance Images with Javascript and AI. Increase resolution, retouch, denoise, and more. Open Source, Browser & Node Compatible, MIT License.
https://upscalerjs.com
MIT License
800 stars 74 forks source link

Demo page is broken #1243

Closed thekevinscott closed 1 year ago

thekevinscott commented 1 year ago

The demo page is currently broken (thanks to @wes-kay on #1217 for the report)

av01d commented 1 year ago

It still is...

wes-kay commented 1 year ago

It still is...

This isn't what I didn't pay for.

I don't particularly need the demo scene as I've seen the outputs as that's all I needed.

Thanks.

av01d commented 1 year ago

It still is...

This isn't what I didn't pay for.

I don't particularly need the demo scene as I've seen the outputs as that's all I needed.

I'm struggling to replicate the demo upscaled images as seen on the homepage of upscalerjs.com. I'm pretty sure I've got things running correctly, but my upscaled images don't look half as good as they do in the demo carousel on upscalerjs.com. A demo page would be very handy to confirm that this lib does what it promises to do in my browser.

thekevinscott commented 1 year ago

The demo page should be fixed now. Please let me know if you're still seeing issues.

The demo is using the esrgan-medium, so if you're comparing models make sure you're comparing to that (I also realize the demo page doesn't say which model it's using; made an issue for that here).

The images from the carousel on the homepage are using esrgan-thick, which is the highest quality but also slowest model. Normally you can run a demo of it in your browser here, but it looks like Codesandbox isn't picking up the latest dependencies that I published, so alternatively you can download the repo and run the demo locally with:

cd models/esrgan-thick/demo
npm install
npm run dev

And you should see it running at http://localhost:5173.

thekevinscott commented 1 year ago

I'll close as fixed, but if you're still seeing issues with the demo I will re-open this and investigate further.

av01d commented 1 year ago

The demo page works now, thanks for that. There's a bug on Firefox though: if you select an image from the Pixabay list on the right, an "The operation is insecure" error is thrown. Probably a crossorigin issue. It does work on Chrome and Safari.

thekevinscott commented 1 year ago

Ah yes, I see that too - thanks for the report. Will reopen this.