Angular 14 Support - Githubissues

thekip / angular-cc-library

Library to support Credit Card input masking and validation

MIT License

81 stars 71 forks source link

Angular 14 Support #109

Closed johnmckay-reward closed 2 years ago

johnmckay-reward commented 2 years ago

Just wondering if work has started on supporting Angular 14?

If not, would be happy to fork the repo and have a go at this myself

Thanks

thekip commented 2 years ago

You are welcome to create a PR. I think only version bump is needed for this release

johnmckay-reward commented 2 years ago

Bumping the versions seems to break the tests for some reason, will update if/when I figure it out, cheers

thekip commented 2 years ago

You probably need to use ng upgrade command to update. There are breaking changes in v14 which might be automatically migrated using Angular CLI schematics

johnmckay-reward commented 2 years ago

Have created a PR for this @thekip

https://github.com/thekip/angular-cc-library/pull/110

johnmckay-reward commented 2 years ago

Have tested on a fresh Angular 14 app, all working as expected with no errors, thanks!