thekompanee / fuubar

The instafailing RSpec progress bar formatter
http://jeffkreeftmeijer.com/2010/fuubar-the-instafailing-rspec-progress-bar-formatter/
MIT License
955 stars 65 forks source link

For version 2.4.1 strange behavior for 'binding.pry' in spec. Version 2.3.2 is OK. #112

Closed foton closed 5 years ago

foton commented 5 years ago

Current Behavior

When I use binding.pry in feature spec, run is stopped, but I cannot use console. Not happened in 2.3.2.

Steps to Reproduce

  1. Set breakpoint binding.pry in some_file_spec.rb
  2. Run bundle exec rspec spec/..../some_file_spec.rb
  3. When execution stops, try to write some command. Progress bar is periodically intercept writen commands. It seems, that it reacts on keypress with small delay (aprox 1second) .

Screenshot

With 2.3.2 Snímek z 2019-07-18 17-13-07

After update to 2.4.1 Snímek z 2019-07-18 17-14-53

Expected Behavior

Environment

jfelchner commented 5 years ago

@foton so sorry about this mate. It turns out that we moved some code around that I didn't think would affect this, but it turns out that it did. I'm going to be removing all Pry support from fuubar in the next release and the auto-refresh functionality will be opt-in. See #109 for more details.

github-actions[bot] commented 3 years ago

This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.